-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(BA-620): Add Service Layer to Avoid Direct Volume and Vfolder Operations in Storage-Proxy Handler #3588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e717a44
to
18e64fb
Compare
cc8a81d
to
02268b8
Compare
a1ed810
to
b6c7b90
Compare
04dc82f
to
01e569b
Compare
… in Storage-Proxy Handler
b6c7b90
to
b867312
Compare
164064a
to
b200f07
Compare
MintCat98
commented
Feb 12, 2025
MintCat98
commented
Feb 12, 2025
MintCat98
commented
Feb 14, 2025
- Added `log_manager_api_entry_new` to correspond with the refactored codes.
HyeockJinKim
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:docs
Documentations
comp:common
Related to Common component
comp:storage-proxy
Related to Storage proxy component
size:XL
500~ LoC
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3554 (BA-620)
Implement volume service layer at service.py.
Also revised some parts of:
for the service operations.
Checklist: (if applicable)
ai.backend.test
docs
directory📚 Documentation preview 📚: https://sorna--3588.org.readthedocs.build/en/3588/
📚 Documentation preview 📚: https://sorna-ko--3588.org.readthedocs.build/ko/3588/